Opened 3 years ago

Last modified 3 years ago

defect #67 (closed: DONE)

Some diff of ticket description are missing

Test Complete Size: 1 Test Complete Date: 05/19/09
Documentation Complete Size: 0 Documentation Complete Date:
Acceptance Complete Size: 1 Acceptance Complete Date: 05/20/09
Reported by: augustinus Owned by: ja11sop
Milestone: Clean up of Plugin with Patch Component: agiletrac patch to core
Version: Keywords:
Cc: Blocked By:
Patch SVN Revision: Patch Trac Version: not_applicable
Blocking:
In Iterations: 19 22

Description

I noticed that Milestone and description content diff are missing after I installed the patched trac of agile-trac.

Is this a known issue?

Change History

Have a look at the list of modified files related to this ticket.

  Changed 3 years ago by ja11sop

  • test_complete_size changed from undefined to 1
  • doc_complete_size changed from undefined to 0
  • acceptance_complete_size changed from undefined to 1

No, thanks for reporting.

  Changed 3 years ago by dfraser

Hmmm, as a logged in user I can't add myself to cc...

follow-up: ↓ 11   Changed 3 years ago by dfraser

This is bad - the changes aren't being stored at all in the ticket_changes table, which means that the change history is not available, it's not just a display issue

  Changed 3 years ago by ja11sop

  • trac_version set to not_applicable

Yes, that's not good. In fact I consider this is one of the highest priority issues (and has been for a while). It is also one of the issues that gates moving to a single patch. That alone is a massive overhead (it works correctly for earlier patch versions). Plus much of the patch needs moved into the plugin where it belongs. I'll look into this as soon as possible. The fact that the entries are not getting persisted should narrow it down. Patches as most welcome.

I can add you to the Cc list if you like?

  Changed 3 years ago by dfraser

Ah, commenting gets me email notification on the ticket so that's fine.

I'll see if I can discover what's behind this next time I get a change to look TM :-)

  Changed 3 years ago by ja11sop

Quick question, what version of the patch were you using and what was the SVN revision?

  Changed 3 years ago by ja11sop

  Changed 3 years ago by ja11sop

  Changed 3 years ago by ja11sop

  Changed 3 years ago by ja11sop

in reply to: ↑ 3 ; follow-up: ↓ 12   Changed 3 years ago by ja11sop

  • test_complete_date set to 05/19/09

Replying to dfraser:

This is bad - the changes aren't being stored at all in the ticket_changes table, which means that the change history is not available, it's not just a display issue

This was the clue that solved it. It turns out some bad python was responsible for this: if there were custom fields it broke, otherwise it was ok. Fix committed to svn. Please update and restart your server to obtain the fix. I'd appreciate it if you could verify it wi working for you now. Many thanks.

in reply to: ↑ 11   Changed 3 years ago by dfraser

Replying to ja11sop:

Replying to dfraser:

This is bad - the changes aren't being stored at all in the ticket_changes table, which means that the change history is not available, it's not just a display issue

This was the clue that solved it. It turns out some bad python was responsible for this: if there were custom fields it broke, otherwise it was ok. Fix committed to svn. Please update and restart your server to obtain the fix. I'd appreciate it if you could verify it wi working for you now. Many thanks.

Tested, definitely fixed - thanks!

  Changed 3 years ago by ja11sop

  • acceptance_complete_date set to 05/20/09
  • status changed from sized to closed
  • resolution set to DONE
Note: See TracTickets for help on using tickets.